Dan Kenigsberg has posted comments on this change.
Change subject: Clean libvirt networks if bridge not exists
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File vdsm/clientIF.py
Line 114: lvNetworks = self._libvirt.listNetworks()
1st call to listNetworks
Line 123: if netinfo.getnetworks()[network]['bridged'] and network
not in netinfo.bridges():
n + 1 more calls to listNetwork.
wouldn't it be better to cache this? netinfo.get() is intended to get such a
cache.
....................................................
File vdsm/configNetwork.py
Line 650: logging.debug('failed to remove libvirt network %s' % netName)
I find exc_info=True very helpful
....................................................
File vdsm/netinfo.py
Line 58: def getnetworks():
Why not call this simply "networks" just the rest of the functions here?
--
To view, visit http://gerrit.ovirt.org/1990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03a8414a0609ca7904cb01fa9b2d9f5c42c9c8d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
