Federico Simoncelli has posted comments on this change. Change subject: Implement storage server connection monitoring ......................................................................
Patch Set 4: (4 inline comments) .................................................... File vdsm/storage/hsm.py Line 293: self._connectionMonitor.restorePersistedConnections() restorePersistedConnections doesn't exists Line 294: self._connectionMonitor.startMonitoring() In the next patch you're moving this to line 279, can you do it now? .................................................... File vdsm/storage/storageServer.py Line 508: with self._activeOpsLock: This method looks quite long and very much indented. Any chance to move something out to an other method? (Eg: this "with" block). .................................................... File vdsm/storage/sync.py Line 22: def result(self): Does this mean that if we ask for the result while it's not completed yet we'll simply get a (None, None)? This means that it can be used only with wait() (and it also assumes that the user doesn't do mistakes). Don't you think it would be better to raise an exception? -- To view, visit http://gerrit.ovirt.org/1694 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc4154650f001f79f27afcc0bed7474ce489c380 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
