Ayal Baron has posted comments on this change. Change subject: Fix remotePath comparison in getStorageDomainsList ......................................................................
Patch Set 7: (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 2119: if remotePath and remotePath != dom.getRemotePath(): before all kinds of refactoring and stuff dom.getRemotePath used to return a path with '/' replaced with underscores. remotePath however contained the path with '/'. Hence, in order to make the comparison you had to transform remotePath to the same format as was returned from the domain. Are you sure that remotePath and dom.getRemotePath now contain the same kind of path? or does this comparison always evaluate to False? -- To view, visit http://gerrit.ovirt.org/1244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50c856f0a612b27672a5c6ccda877979455b00f5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
