Adam Litke has posted comments on this change.
Change subject: [WIP] MOM Integration
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File vdsm/clientIF.py
Line 91: self.ksmMonitor = ksm.KsmMonitorThread(self)
You can combine this if clause into the above if statement.
....................................................
File vdsm/config.py.in
Line 146:
Hmm, I am not sure that we actually need this config option. Eventually we
will always want to use MOM when it is installed so the only safety check we
need right now is one that re-enables the KSM thread when MOM fails to load.
....................................................
File vdsm/mom.conf
Line 29:
You can remove Balloon since the current vdsm policy is not using the Balloon
Controller.
....................................................
File vdsm/vdsMOM.py
Line 48:
There has been a recent move to stop using the traceback.format_exc() function
in logging calls. Please change to:
self._cif.log.error("MOM initialization failed", exc_info=True)
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
