Eduardo has posted comments on this change. Change subject: BZ#798211 - Normalize hibernation images ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Starting a discussion by Igor's request. .................................................... File vdsm/API.py Line 552: device='disk'), \ This is another hack. Now, we understand that this flow was broken (by my self) when the conditions of clientIF.preparePath() were changed to filter out PDIV CDROM. In this way this will happen again. It has gone too far and we should not continue to add semantics into this function. The right thing to do is IMHO to make preparePath() a Drive method. Make the source ready, be "ready" whatever is required, e.g activate an LV or a group of LV's, mounting an export , etc, is a source function and it is unrelated to the flow. -- To view, visit http://gerrit.ovirt.org/2431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1271c5501b129caf28aca7d4be2dbf45d9b32842 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
