Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Implement storage server connection aliasing ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/storage/storageServer.py Line 380: class IlligalAliasError(RuntimeError): pass Illegal I'd also prefer to see pass on a new line and an empty line between classes, but that might be my style -- To view, visit http://gerrit.ovirt.org/1693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cedeb6c8935a2f7846a181e9d2b04046af1002a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: shu ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
