Eduardo has posted comments on this change. Change subject: Expose a custom property for tunnelled migration of a VM ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/libvirtvm.py Line 428: tunnelled = libvirt.VIR_MIGRATE_TUNNELLED May be worth a comment, before someone spell on you? Note the less-common spelling that we're stuck with: VIR_MIGRATE_TUNNELLED should be VIR_MIGRATE_TUNNELED Line 430: tunnelled = 0 conf custom can be changed on a live VM? If not, IMHO tunnelled calculus should be done when we are creating the object and not here. May be all the virDomainMigrateFlags too. -- To view, visit http://gerrit.ovirt.org/2551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id713b455db4f9bf437720b64c92bba9377cd89ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
