Dan Kenigsberg has posted comments on this change.

Change subject: Backing VG's should be named as SD name. Renaming VG's is not 
supported.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

I have no idea why we had this code path in the past (maybe to utilize an 
existing, differently named VG?).

However this is never used by Engine, and it should not, as it may introduce a 
metadata-changing operation on HSM.

--
To view, visit http://gerrit.ovirt.org/2602
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49ad2b24dbc7595ad52e04c3664d51f6d7f27036
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to