Dan Kenigsberg has posted comments on this change. Change subject: Re-organized internal network APIs in API bridge ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/API.py Line 910: def __init__(self, cif): what does a "Network" object represent? How many such objects do you perceive? Note that setupNetworks (intentionally) works on several networks. However you have let setSafeNetConfig in General. So the motivation for this patch is not completely clear to me. Maybe if you send a following patch using this refactoring. -- To view, visit http://gerrit.ovirt.org/2663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64771991c3db09247f7689e6b5ddffa8adbf6745 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
