Dan Kenigsberg has posted comments on this change. Change subject: Added lsblk tool support in supervdsm. ......................................................................
Patch Set 4: I would prefer that you didn't submit this Ewoud, I fell into this trap myself, but I do not think that it is good practice to add major changes (such as a unittest) to someone else's patch. Note that lsblk is not part of the vdsm python package so your test_lsblk would not work. I would very much appreciate if you add this unittest as a separate patch on top of Bala's. -- To view, visit http://gerrit.ovirt.org/2594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0b575fea9a46ac6358adf1b10a66c262888e0e4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
