Igor Lvovsky has posted comments on this change.
Change subject: vds_bootstrap: add flags for installVirtualizationService and
installGlusterService
......................................................................
Patch Set 5: Verified; Looks good to me, approved
(1 inline comment)
Verified by Haim
....................................................
File vds_bootstrap/vds_bootstrap_complete.py
Line 79: logging.debug("installVirtualizationService = '%s',
installGlusterService = '%s'"%(installVirtualizationService,
installGlusterService))
I preferred spaces between '%s' and lines < 80 .
But, it's a bootstrap and it's anyway very ugly
--
To view, visit http://gerrit.ovirt.org/2504
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I883a5c36ff72a7c59b3e6a8b33d06924a5781d20
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
