Federico Simoncelli has posted comments on this change. Change subject: Make sure that internally we always use pvs from /dev/mapper/ ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) I like to read stuff from /sys. .................................................... File vdsm/storage/lvm.py Line 197: return "/dev/mapper/" + guid At least we should reuse one of the defined paths: lvm.py:PV_PREFIX = "/dev/mapper" devicemapper.py:DMPATH_FORMAT = "/dev/mapper/%s" -- To view, visit http://gerrit.ovirt.org/2940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I195f51125903b3d913c542a285a463bf26810d87 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
