Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: bootstrapping: avoid usage of tmp folder
......................................................................
Patch Set 1: (4 inline comments)
I like the initiative, but it feels a bit inconsistent. Maybe you determine
workdir once in main() and pass it it all functions?
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 60: log_filename = SCRIPT_DIR + 'vds_bootstrap.' + rnum + '.log'
Why use SCRIPT_DIR here and in the other file /tmp if isOvirt() else SCRIPT_DIR?
....................................................
File vdsm_reg/deployUtil.py.in
Line 154: workdir = '/tmp/'
Why not tempfile.gettempdir()
Line 1120: workdir = '/tmp/'
Why not:
workdir = tempfile.gettempdir() if isOvirt() else SCRIPT_DIR
Line 1127: gGroup = grp.getgrnam('VDSM_GROUP')
Why should this be quoted?
--
To view, visit http://gerrit.ovirt.org/2277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b5df6dd0b5ff0bdf648cd74d160384b86e5bbf7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
