Adam Litke has posted comments on this change. Change subject: Rename volumeCopy API to volumeCollapse ......................................................................
Patch Set 3: (1 inline comment) I would suggest selecting an even better name for this function since you are renaming it. .................................................... Commit Message Line 8: Can I suggest a different name for this function? volumeCollapse implies an in-place operation that modifies the current object. volumeFlattenedCopy() ? -- To view, visit http://gerrit.ovirt.org/2968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide39bb54d2a97b3ba8d4712750ff10a67c5764f2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
