Dan Kenigsberg has posted comments on this change. Change subject: Define some constants in API.py ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (2 inline comments) approach looks good to me, but 2 minor questions within. .................................................... File vdsm/API.py Line 760: DEFAULT_VERSION = storage.sd.DOM_SAFELEASE_VERS[0] why would we want DEFAULT_VERSION exposed in the API? Line 945: MAX_HOST_ID = storage.safelease.MAX_HOST_ID pardon, but why this has to be exposed to Vdsm API users? -- To view, visit http://gerrit.ovirt.org/2262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
