Dan Kenigsberg has posted comments on this change.
Change subject: Integrate nosetests to vdsm testing
......................................................................
Patch Set 2: Verified; I would prefer that you didn't submit this
(2 inline comments)
wow. finally.
....................................................
File tests/testrunner.py
Line 25: from nose import config
we should now BuildRequire: python-nose
or should we let skipping %check in `make rpm` ?
Line 29: COLORS = {"black": 30,
do we have to use misspellable strings as color names? I prefer the 'class'
approach for enums, or even plain constants.
--
To view, visit http://gerrit.ovirt.org/3257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8d761ac0c03adf25324ea04e948b98faa82e39
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
