Dan Kenigsberg has posted comments on this change. Change subject: Add fileUtil unit tests ......................................................................
Patch Set 3: (1 inline comment) .................................................... File tests/testrunner.py Line 159: # Remove this when source is properly orgenized. s/orgenized/.. I do not understand this hack, and I do not know how it cat be reasonably be extended to incorporate all testable modules. I would prefer the tests to assume that the git repo structure below vdsm is a superset of the sitelib vdsm package. Wouldn't it work "by chance"? If that's too ugly/impossible, how about creating a shadow sitelib under /tmp when testrunner starts? -- To view, visit http://gerrit.ovirt.org/3264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I346eeb5598670b10163b09ad0b99a1527359fca0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
