Dan Kenigsberg has posted comments on this change.

Change subject: Fix some code didn't use VDSMUSER
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

ahh, so much noise...

I'm not sure about changing the hooks, they are unsupported examples, and may 
be better off left as they are. I really do not know.

minor patch-splitting comment inline.

....................................................
File vdsm/sudoers.vdsm.in
Line 44:     @SETSID_PATH@ @IONICE_PATH@ -c? -n? @SU_PATH@ @IOUSER@ -s /bin/sh 
-c /usr/libexec/vdsm/spmprotect.sh*, \
this belongs to the former patch!

--
To view, visit http://gerrit.ovirt.org/3363
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f834b1b34ffcdbbf32a1f5cd9e7728976b623c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to