Ryan Harper has uploaded a new change for review.

Change subject: pylint: vdsm/netinfo.py
......................................................................

pylint: vdsm/netinfo.py

************* Module netinfo
E: 45,23:nics: Instance of '_Chainmap' has no 'split' member (but some types 
could not be inferred)
E:137,22:ifconfig: Instance of 'list' has no 'split' member (but some types 
could not be inferred)
E:377,16:NetInfo.getNicsVlanAndBondingForNetwork: Function 'nics' has no 
'append' member

applied some str() conversions.  For the nics append, there is a global 
function called 'nics'
which pylint says is the same as the local variable (list) 'nics'.  I renamed 
the function to
be more descriptive: def nics() -> def enumerate_nics() and modified caller.

Change-Id: Iee990e661acb15504e180dd3005aaa048153326c
Signed-off-by: Ryan Harper <[email protected]>
---
M vdsm/netinfo.py
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/3441/1
--
To view, visit http://gerrit.ovirt.org/3441
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee990e661acb15504e180dd3005aaa048153326c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to