Dan Kenigsberg has posted comments on this change. Change subject: pylint: vdsm:caps.py convert output to string ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 10: E:187,35:osversion: Instance of 'list' has no 'splitlines' member (but some types could not be inferred) but why does pylint think that in out, err = subprocess.Popen.communicate() 'out' is a list? It is as str as it is. Silencing pylint with explicit casting is not out of the question, however I'd again prefer one sweeping patch that fixes this supposed error wherever communicate is used. -- To view, visit http://gerrit.ovirt.org/3438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I581b336fa63ea41258d374419fb70970435cdca9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
