Ayal Baron has posted comments on this change. Change subject: Add persistentDictTests ......................................................................
Patch Set 2: I would prefer that you didn't submit this (3 inline comments) .................................................... File tests/persistentDictTests.py Line 29: # (C) Valve - Portal 2 is it legal to put these quotes here? or is it copyright infringement? Line 60: 'he thought to himself, "where the worst type of women"' s/where/were/ Are you quoting from memory? because I think you are not true to the source here. Line 65: def testFaileNestedTransaction(self): testFaile"d"? -- To view, visit http://gerrit.ovirt.org/3496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib00d930051341dce6f1a986ac44cf0690b97c000 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
