Dan Kenigsberg has posted comments on this change. Change subject: pylint:vdsm/netinfo.py rename nics() function to avoid overload with local variable ......................................................................
Patch Set 2: I would prefer that you didn't submit this netinfo.nics() is used in clientIF. this patch breaks a symmetry with the bridges(), vlans() functions etc. How about changing the name of the local variable instead? -- To view, visit http://gerrit.ovirt.org/3445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I295b87a9c1d1858771b28886d8966faafd4be077 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
