Igor Lvovsky has posted comments on this change. Change subject: [WIP] Refactor Pool.deleteImage() Added sd.getTemplateSelfImg() ......................................................................
Patch Set 3: I would prefer that you didn't submit this (5 inline comments) I need author's explanation for this patch .................................................... File vdsm/storage/sp.py Line 1717: # 1) if template image with dependent images, replace by fake This is right only for Export domain Line 1718: # 2) if regular image dependent on fake remove image and fake remove fake only if no more images dependes it Line 1720: # 4) if regular image template based remove image 3 & 4 are same. you always can delete regular image Line 1721: # May be worth block file differentiation? why? Line 1741: tName, tImgs, tParent = ts[0][0], ts[0][1][0], ts[0][1][1] Sorry man, but I think noone could understand without proper comments what did you meant here -- To view, visit http://gerrit.ovirt.org/3464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
