Igor Lvovsky has posted comments on this change. Change subject: [WIP] Check move image conditions from SD data. ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/hsm.py Line 1288: def isImageMoveLegal(self, srcDom, dstDom, imgUUID): If you decided to keep this function in hsm, I think it should be in the class but not global (maybe classmethod). Anyway, don't put the global function in the middle of the class functions. -- To view, visit http://gerrit.ovirt.org/3466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2422217717fe0f3cb668b4dc5f775e4a971c8d9b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
