Igor Lvovsky has posted comments on this change.
Change subject: fix check None sdUUID for getVmsList and getVmsInfo
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1136: self.validateBackupDom(sdUUID)
Ayal, you have this behavior on several places in the code.
So, If you want to support future OVF spreading among different domains
let's do it in separate patch in ALL places.
This patch fix very particular BZ, let's keep it like this
Line 1159: if sdUUID and sdUUID != sd.BLANK_UUID:
Ah, I saw it but I didn't want to bothering you with this one too, because this
not related to your BZ.
But if you already touched it and only if you will send another patch for this.
Please fix it to:
if sdUUID != sd.BLANK_UUID:
the sdUUID can't be None here or put default None to function call
--
To view, visit http://gerrit.ovirt.org/3560
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27fe906e6738320279bc44f9736acaa97131d7ee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
