Douglas Schilling Landgraf has posted comments on this change.
Change subject: improve add/del bridgesless network
......................................................................
Patch Set 3: (9 inline comments)
....................................................
Commit Message
Line 11:
I will provide a specific patch.
....................................................
File vdsm/configNetwork.py
Line 746: removeLibvirtNetwork(vlandev)
Indeed, I will provide a new patch not touching in these lines.
....................................................
File vdsm/netinfo.py
Line 93: if os.path.exists(os.path.join(bridgePath)):
This part of change will be aborted, not required anymore.
Line 94: ports = os.listdir(bridgePath)
This part of change will be aborted, not required anymore.
Line 103: mtu = file(ifacePath).readline().rstrip()
This part of change will be aborted, not required anymore.
Line 113:
This part of change will be aborted, not required anymore.
Line 274: # interface already removed!
Correct, new patch won't touch in this part.
....................................................
File vdsm_reg/deployUtil.py.in
Line 42: sys.path.append("/usr/share/vdsm")
ok, agreed.
Line 900: configNetwork.createLibvirtNetwork(mgtBridge,
bridged=True)
Ok, I will send a new patch to review.
--
To view, visit http://gerrit.ovirt.org/3615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f170eaced2d6f756b84cb52e9efce6dc9722405
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
