Dan Kenigsberg has posted comments on this change. Change subject: Remove (almost all) class Volume virtual (!) methods. ......................................................................
Patch Set 2: I've never understood your vendetta against pure virtual functions in Python. The functions that you are removing should have raised "UnimplentedError" instead of returning None, but other than that, they have merit for documenting the abstract class. -- To view, visit http://gerrit.ovirt.org/3461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib14c4d398aa68edbd9a413506b2cc4d8615c686b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
