Igor Lvovsky has posted comments on this change.

Change subject: [WIP] Don't waste SD produces in validateSdUUID.
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(2 inline comments)

If you started to do it, please do it in all proper places.

....................................................
File vdsm/storage/hsm.py
Line 1304:         if not sdCache.produce(dstDomUUID).isBackup():
what about this one?

Line 1337:         if not sdCache.produce(dstDomUUID).isBackup():
what about this one?

--
To view, visit http://gerrit.ovirt.org/3465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9caea51dec6063c978cad3f9403628e15062582
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to