Dan Kenigsberg has posted comments on this change. Change subject: Use more descriptive exceptions for blocksize errors. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) could you explain the motivation for this (and the compatible change in Engine)? wouldn't a text string reporting the phys and logical size do a better job? .................................................... File vdsm/storage/lvm.py Line 897: raise se.DevicePhysicalBlockSizeError(pvBlkSize) the name is more descriptive, but less exact. PhysicalBlockSize is not really "bad" here. It is its relative size to LogicalBlockSize that is bad... -- To view, visit http://gerrit.ovirt.org/3688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
