Dan Kenigsberg has posted comments on this change. Change subject: replace ifconfig cmdline with ethtool and sysfs in netinfo ......................................................................
Patch Set 8: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/netinfo.py Line 143: netmask_hex = ((1L<<netmask)-1)<<(32-netmask) could you split this to a new function? it begs for a unit test... -- To view, visit http://gerrit.ovirt.org/3361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e0ce521406c8f499db2ff449c5df47716a2eb23 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: David Naori <davidnao...@gmail.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Peter V. Saveliev <p...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
