Dan Kenigsberg has posted comments on this change.

Change subject: when build vdsm, run_tests.sh runs two times it take a long 
time, remove the "make check" in vdsm.spec.in
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I think that the %check section is educationally important - that's how rpms 
should be made.

Where is the second place `make check` is called? I see it only there when I 
`make rpm`.

Note again that you can skip nose tests altogether with NOSE_EXCLUDE.

--
To view, visit http://gerrit.ovirt.org/3907
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7fdc920f997c479a6b65474a53043fb4f504c84
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to