Mark Wu has posted comments on this change.
Change subject: Introduce API setBalloonTarget
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/vm.py
Line 405: dev['target'] = int(self.conf.get('memSize', 256)) *
1024
Yes, I could add the default memory size to config.py.in. But I find that the
parameter 'memSize' is already validated in API.VM.create(). So it should be
safe to use it directly. In next version, I am going to change it to:
self.conf.get('memSize')
--
To view, visit http://gerrit.ovirt.org/3669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
