Ayal Baron has posted comments on this change. Change subject: Make the xmlrpc binding run in a thread ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/clientIF.py Line 156: while self._enabled: why do we keep this thread alive and not join as part of prepareForShutdown? -- To view, visit http://gerrit.ovirt.org/3891 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic0ea2589d5cb258c4b8d3d82d4f9c390b702a24f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
