Dan Kenigsberg has posted comments on this change. Change subject: rest-api: Add the basic server infrastructure ......................................................................
Patch Set 5: (2 inline comments) .................................................... File vdsm/rest/Dispatcher.py Line 2: # All rights reserved. IANAL, but I think there's any problem with a BSD file in Vdsm. GPL infects it anyway. But don't you own your tweaks for it? shouldn't you state it, too? oh, and there's whitespace noise. Line 54: This is the default, built-in dispatcher for CherryPy. don't you want to change the docstring? it slightly lies... -- To view, visit http://gerrit.ovirt.org/2021 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: ShaoHe Feng <shao...@linux.vnet.ibm.com> Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com> Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches