Shahar Havivi has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 27: (6 inline comments)

....................................................
File vdsm/clientIF.py
Line 200:             #TODO: REMOVE payload from getVmStats
Done

....................................................
File vdsm/mkimage.py
Line 36: def _decodeFilesIntoDir(files, dirname=None):
Done

Line 43:     :param files: [{'filename': 'content' }, {'filename': 'content'}]
Done

Line 48:         dirname = tempfile.mkdtemp()
we had this discussion and it was ping pong from /tmp to /var

Line 81:             m.mount(mntOpts='loop')
Done

....................................................
File vdsm.spec.in
Line 593: %ghost %dir %{_localstatedir}/run/%{vdsm_name}/pools
Done

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to