Gal Hammer has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Looks okay, other than a minor comment. .................................................... File vdsm/libvirtvm.py Line 838: if not hasattr(self, attrName): nit: I would prefer to see a "if hasattr" condition rather than a "continue". -- To view, visit http://gerrit.ovirt.org/4132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2e1c5a2d0998af38fa80d53975b0e528b9257a6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hans De Goede <hdego...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Hans De Goede <hdego...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
