Dan Kenigsberg has posted comments on this change. Change subject: rest-api: Add unit tests ......................................................................
Patch Set 3: (1 inline comment) posting an old forgotten draft comment. .................................................... File vdsm/rest/Controller.py Line 484: raise cherrypy.HTTPError(400, "A required parameter is missing") wouldn't it be cooler to report which param is missing with e.args[0] a context manager that encapsulate this repeated code could be even cooler -- To view, visit http://gerrit.ovirt.org/3757 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife07553718315136bbb5a74558dd189dee4e475f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
