Dan Kenigsberg has posted comments on this change. Change subject: configNetwork: fix remove bridge flow ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) .................................................... File vdsm/configNetwork.py Line 743: removeLibvirtNetwork(network) but the libvirt network should have been removed here! Maybe what you should do is not pass the skipLibvirt flag? Line 748: if network and bridged: not your patch, but "if network"?! network is always defined here. -- To view, visit http://gerrit.ovirt.org/4342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie98ba38da64e34aedfd88b11880929ee4d99d0d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
