Xu He Jie has posted comments on this change. Change subject: make compression type configurable, support gzip and xz ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File configure.ac Line 42: AC_PATH_PROG([XZ], [xz]) for logrotate compress type, I think it should not only decided by check. This check only test the build machine, it not on target machine. It should support configure argument like '--with-xz, --with-gzip'. if user didn't specific which one want to use, then it can be decide by check. -- To view, visit http://gerrit.ovirt.org/4174 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
