Saggi Mizrahi has posted comments on this change.
Change subject: introducing test package to vdsm
......................................................................
Patch Set 4: (7 inline comments)
This patch does too many things and is a bit confusing, please have every
change in it's own patch.
I still don't understand why you want to move the files around.
....................................................
File tests/testrunner.py
Line 156: def search_files(path, suffix):
Remove this function, use glob
Line 186: print "running test suits %s..." % case_unit["name"]
stream.write
Line 220: parser.add_argument('--case', help='''specify a case or a
directory
This entire option is redundant, it's already built in, just add the ut folder
to nose's search path.
This will not solve the issue of being able to tab to autocomplete module names
Line 225: inputArgs = sys.argv[1:]
There is no need to eliminate the first arg
Line 226: args = parser.parse_args(inputArgs)
Pop your args from the agrv list so they don't confuse nose.
Line 240: print "hacking vdsm modles..."
stream.write
Line 244: def genCaseList(testConfig):
Again, this entire function is redundant, just add ./ut to nose's search path.
--
To view, visit http://gerrit.ovirt.org/3923
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I193950b73a9bc1583433c3814f4c7d028f01ecd0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com>
Gerrit-Reviewer: Shu Ming <shum...@linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/vdsm-patches
