Lei Li has posted comments on this change. Change subject: Get network address to showNetwork ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 708: ipaddr = netdict['addr'] Yes, bridgeless networks may have ipaddress, but seems it's not supported by vdsm now. vdsm create bridgeless network through libvirt just with network name and its interface, so both libvirt and host did not have these info. Should we let it supported first? Or mark it as a TODO if there are other plans? -- To view, visit http://gerrit.ovirt.org/4326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I791adbb9321d097fb609f0328e25d6d4f1865696 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches