Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsmd.init: remove validation to reload config ......................................................................
Patch Set 1: > Does this solve a real problem? Yes, we do not validate a non existing path/file. /usr/share/doc/libvirt.0.X.Y/libvirtd.upstart > I think that in oVirt > node, there is never a new version of libvirt that is > introduced, so we never need to reload-configuration. > `initctl reload-configuratoin` is not something that > normal sysV services do, so it carries a surprise factor I > would like to avoid. Well, users can modify the file /etc/init/libvirt.conf and next time they execute /etc/init.d/vdsmd start it will load the new configuration automatically. If you think we don't need to worry about it, I am ok to remove the the reload-configuration stuff too. Please let me know your opinion. -- To view, visit http://gerrit.ovirt.org/4479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
