Dan Kenigsberg has posted comments on this change. Change subject: BZ#788640 - Check move image conditions from SD data. ......................................................................
Patch Set 12: I would prefer that you didn't submit this (2 inline comments) -0.2, actually. .................................................... File vdsm/storage/hsm.py Line 1307: # Filter volumes related to this image if you need such a comment, the name of sd.getVolsOfImage() is not clear enough. how about sd.filterAllVolsByImage() ? Line 1315: if imgUUID != tImgs[0] and tName not in dstAllVols.keys(): keys() is a needless copy -- To view, visit http://gerrit.ovirt.org/3466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2422217717fe0f3cb668b4dc5f775e4a971c8d9b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
