Zhou Zheng Sheng has uploaded a new change for review. Change subject: Let LC_ALL=C when running tests ......................................................................
Let LC_ALL=C when running tests The function validateDDBytes() in vdsm/storage/misc.py needs C locale. When vdsm runs /bin/dd, the stderr output of /bin/dd is inspected by validateDDBytes(). Then the last line of the output is splitted by space and the 0th word is the total count of bytes transferred. In a locale like zh_CN.utf8(Chinese), the stderr output message is different from that in C locale. Although dd runs successfully, validateDDBytes() can not take out the count of the bytes transferred, and an exception will be raised. When vdsmd is started by vdsmd.init, LC_ALL is set to C to provide a compatible locale for vdsmd. However, when running tests, the locale is not set to C. So "make check" will fail in a zh_CN.utf8 locale in all tests related to dd, and this causes "autobuild.sh" and "make rpm" fail as well. So, set LC_ALL=C will provide a standard locale for running the tests. Change-Id: I93176e8948aea11cb6adf11d8dc295e43bb1dfee Signed-off-by: Zhou Zheng Sheng <[email protected]> --- M tests/run_tests.sh.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/4243/1 -- To view, visit http://gerrit.ovirt.org/4243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I93176e8948aea11cb6adf11d8dc295e43bb1dfee Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
