Bing Bu Cao has posted comments on this change. Change subject: Fixing pep8 in vdsm/storage/fileVolume.py ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/storage/fileVolume.py Line 422: getImage() == imgUUID): I think both way are OK. Put "." at head of the line make the code more neat. But put "." at the trail of the line,the code will be consistent with lines end with "," : pattern = os.path.join(repoPath, sdUUID, sd.DOMAIN_IMAGES, 415 imgUUID, "*.meta") -- To view, visit http://gerrit.ovirt.org/4541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e1ce2aef9ac4be974529ecaf76d5dc5a578d92d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
