Zhou Zheng Sheng has posted comments on this change.

Change subject: change the code style of devicemapper.py for PEP8 compliance
......................................................................


Patch Set 1: (3 inline comments)

The problem I find is false-alarm. It's my browser's problem, and your code 
indentation is right. I'm sorry.

....................................................
File vdsm/storage/devicemapper.py
Line 38:                       "Could not find dm device named `%s`" % path)
It's my browser problem, sorry. The indentation is no problem.

Line 56:                          "Parameter is not a devname `%s`" % devName)
It's my browser problem, sorry. The indentation is no problem.

Line 61:                          "Parameter is not a devname `%s`" % devName)
It's my browser problem, sorry. The indentation is no problem.

--
To view, visit http://gerrit.ovirt.org/4514
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66cf0d4c0726a1c4f5824b60246649aae18db746
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to