Saggi Mizrahi has posted comments on this change.
Change subject: Tunnel errors from child to parent in betterPopen
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/betterPopen/createprocess.c
Line 266: if (read(errnofd[0], &childErrno, sizeof(int)) == sizeof(int)) {
Using waitpid() is raceful, you don't know if it's an error or the process
returned quickly.
--
To view, visit http://gerrit.ovirt.org/4413
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d4a132317e9cf0843671460a0876f615760731d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
