Ayal Baron has posted comments on this change.

Change subject: BZ#788640 - Template relink refactored.
......................................................................


Patch Set 14: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/storage/image.py
Line 400:             # Assumed that the new replace template was already 
created.
Please get rid of this comment.

Line 405:             oop.getProcessPool(destDom.sdUUID).os.link(os.path.join(
link(tempName)
mv(newName)
to make it atomic?

--
To view, visit http://gerrit.ovirt.org/3467
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I087fc777e202088615c82be1a88fcde15b846628
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to