Dan Kenigsberg has submitted this change and it was merged. Change subject: storage: Move nfsSD.getFileUtils() to FileStorageDomain class ......................................................................
storage: Move nfsSD.getFileUtils() to FileStorageDomain class If I create an iso-domain out of a LOCALFS storage type, when I call getIsoList on the storage pool which includes the iso-domain vdsm complains that LocalFS does not have getFileList method. The nfsSD class has the exact method for finding files that is needed. By moving the implementation to the base class for both nfs and localfs types, they can share the implementation. Change-Id: I31cf133464751ffcf222140e83fa8d0e32940c05 Signed-off-by: Ryan Harper <[email protected]> --- M vdsm/storage/fileSD.py M vdsm/storage/nfsSD.py 2 files changed, 35 insertions(+), 34 deletions(-) Approvals: Adam Litke: Looks good to me, but someone else must approve Ryan Harper: Verified Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Eduardo: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31cf133464751ffcf222140e83fa8d0e32940c05 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ryan Harper <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
