Ayal Baron has posted comments on this change. Change subject: BZ#788640 - Remove subChainSizeCalc() and getSubChain(). Remove getAllChildrenList(). ......................................................................
Patch Set 17: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/storage/image.py Line 1036: return min(accumulatedChainSize, imageApparentSize) * 1.1, chain This function should just return accumulatedChainSize. It is up to the calling function to determine the usage and add the extra 10%, it has nothing to do with the "actual" size calculation -- To view, visit http://gerrit.ovirt.org/3468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffbbf71269eddb53c032c381d10e20b771c47c6b Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Haim Ateya <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
